Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Lockable Extension for ERC-721 #7066

Merged
merged 57 commits into from
Jun 26, 2023
Merged

Add EIP: Lockable Extension for ERC-721 #7066

merged 57 commits into from
Jun 26, 2023

Conversation

streamnft-tech
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels May 25, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 25, 2023 •
edited
Loading

File EIPS/eip-7066.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title erc721lockable init Add EIP: ERC721 Lockable May 25, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 25, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 25, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 25, 2023
@eth-bot eth-bot changed the title Add EIP: ERC721 Lockable Add EIP: ERC-721 Lockable May 25, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 25, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 25, 2023
@streamnft-tech streamnft-tech dismissed a stale review via 990d9ff May 25, 2023 06:15
@eth-bot eth-bot removed the a-review Waiting on author to review label Jun 17, 2023
Piyush and others added 2 commits June 17, 2023 16:21
@eth-bot eth-bot added a-review Waiting on author to review and removed e-review Waiting on editor to review labels Jun 17, 2023
streamnft-tech
streamnft-tech commented Jun 18, 2023
View reviewed changes
EIPS/eip-7066.md
* @dev Lock the tokenId if msg.sender is owner and set locker to _locker
*/
function lock(uint256 tokenId, address _locker) external;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sullof , thanks for the suggestion. I have tried to remove redundancies in ERC7066 and I believe EIP6982 is using couple of more functions to achieve the locking functionality. Effectively ERC7066 has lesser code and optimized gas. Let me know your thoughts

assets/eip-7066/ERC7066.sol Show resolved Hide resolved
SamWilsn
SamWilsn previously approved these changes Jun 19, 2023
View reviewed changes
@streamnft-tech
Copy link
Contributor Author

eth-bot rerun

@eth-bot eth-bot added e-review Waiting on editor to review and removed a-review Waiting on author to review labels Jun 19, 2023
@SamWilsn
Copy link
Contributor

@eth-bot rerun

@SamWilsn SamWilsn merged commit 4fe16ae into ethereum:master Jun 26, 2023
9 checks passed
@piyush-chittara piyush-chittara mentioned this pull request Jul 25, 2023
Closed
21 tasks
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
@SamWilsn
Add EIP: Lockable Extension for ERC-721 (ethereum#7066)
5bedd87 
* erc721lockable init

* update discussion

* update license

* update readme

* add eip header

* update title

* update readme

* update readme

* update readme

* update readme

* update eip number

* update eip number

* update eip number

* update eip number

* update eip number

* update readme

* update readme

* update readme

* update readme

* error codes

* added interface to specification

* lint fixe

* transfer with lock/approve

* rename

* readme update

* optimize lock/unlock

* readme with new functions

* readme update

* error codes

* discussion link

* tokenId

* remove redundancy

* updates test

* updates doc

* review fixes

* overrides and interface correction

* add locker to transferAndLock

* remove locker

* license

* doc update

* doc update

* doc update

* author updates

---------

Co-authored-by: piyush.chittara <[email protected]>
Co-authored-by: Piyush <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
@SamWilsn @RaphaelHardFork
Add EIP: Lockable Extension for ERC-721 (ethereum#7066)
f478976 
* erc721lockable init

* update discussion

* update license

* update readme

* add eip header

* update title

* update readme

* update readme

* update readme

* update readme

* update eip number

* update eip number

* update eip number

* update eip number

* update eip number

* update readme

* update readme

* update readme

* update readme

* error codes

* added interface to specification

* lint fixe

* transfer with lock/approve

* rename

* readme update

* optimize lock/unlock

* readme with new functions

* readme update

* error codes

* discussion link

* tokenId

* remove redundancy

* updates test

* updates doc

* review fixes

* overrides and interface correction

* add locker to transferAndLock

* remove locker

* license

* doc update

* doc update

* doc update

* author updates

---------

Co-authored-by: piyush.chittara <[email protected]>
Co-authored-by: Piyush <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@SamWilsn @GAEAlimited
Add EIP: Lockable Extension for ERC-721 (ethereum#7066)
a6ee997 
* erc721lockable init

* update discussion

* update license

* update readme

* add eip header

* update title

* update readme

* update readme

* update readme

* update readme

* update eip number

* update eip number

* update eip number

* update eip number

* update eip number

* update readme

* update readme

* update readme

* update readme

* error codes

* added interface to specification

* lint fixe

* transfer with lock/approve

* rename

* readme update

* optimize lock/unlock

* readme with new functions

* readme update

* error codes

* discussion link

* tokenId

* remove redundancy

* updates test

* updates doc

* review fixes

* overrides and interface correction

* add locker to transferAndLock

* remove locker

* license

* doc update

* doc update

* doc update

* author updates

---------

Co-authored-by: piyush.chittara <[email protected]>
Co-authored-by: Piyush <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@LocalLegend517 LocalLegend517 LocalLegend517 approved these changes

@flexibrah flexibrah flexibrah approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

@sullof sullof Awaiting requested review from sullof

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@streamnft-tech @eth-bot @piyush-chittara @SamWilsn @sullof @LocalLegend517 @flexibrah