Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Lockable Extension for ERC-721 #7066
Add EIP: Lockable Extension for ERC-721 #7066
Changes from 49 commits
a47a153
a8ed235
ae7c47d
b9f6c76
6671aae
d1bdba3
b0d7f74
ab1866e
82b4ed1
59d0de1
964ba2e
2d23193
990d9ff
d339b67
b8dcef0
930ec58
5bfacfe
624b444
548f97e
8c55c14
9166465
383f2b4
42c2c4e
fbec9a7
c6cb04e
e7383b9
3dc3465
9499213
44170bb
deee3f8
452b536
95609b4
7d7da36
73601d1
1c38c46
fa29104
b2b2df3
6e442df
ce80ffa
f059e05
e8bc642
9bc7fe7
9147291
8422c63
0b40ce1
cb8f306
2afa055
0bfb0f8
1e15d1d
ab46fa0
943374a
94c8e7a
5dc7ee4
fec2757
f7f0826
e314b93
c5beb51
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can extend https://eips.ethereum.org/EIPS/eip-6982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may add to ERC-6982 a second event that accept the locker as parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sullof , thanks for the suggestion. I have tried to remove redundancies in ERC7066 and I believe EIP6982 is using couple of more functions to achieve the locking functionality. Effectively ERC7066 has lesser code and optimized gas. Let me know your thoughts