Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Linter Scope #7199

Merged
merged 8 commits into from
Jun 23, 2023
Merged

Add EIP: Linter Scope #7199

merged 8 commits into from
Jun 23, 2023

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Jun 20, 2023 •
edited
Loading

Reflecting #7198

@xinbenlv xinbenlv requested a review from eth-bot as a code owner June 20, 2023 21:26
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 20, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Create EIP-7198: Linter Scope Add EIP: Linter Scope Jun 20, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jun 20, 2023
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-meta labels Jun 20, 2023
@xinbenlv xinbenlv mentioned this pull request Jun 20, 2023
Closed
abcoathup
abcoathup reviewed Jun 22, 2023
View reviewed changes
EIPS/eip-7198.md Outdated Show resolved Hide resolved
@xinbenlv @abcoathup
Update EIPS/eip-7198.md
83a4201 
Co-authored-by: Andrew B Coathup <[email protected]>
@github-actions
Copy link

The commit 83a4201 (as a parent of 8df204b) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 22, 2023
@xinbenlv
Copy link
Contributor Author

Thank you @abcoathup, same as you, I am a big fan to avoid special treatment being an Editor, just like I said in this post.

I have no objection to use 7198 or 7199 or any number. Since you prefer 7199 I am going with what you want.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 22, 2023
@xinbenlv xinbenlv marked this pull request as draft June 22, 2023 21:33
@xinbenlv xinbenlv marked this pull request as ready for review June 22, 2023 23:12
@eth-bot eth-bot enabled auto-merge (squash) June 23, 2023 16:25
eth-bot
eth-bot approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 4421527 into ethereum:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@eth-bot eth-bot eth-bot approved these changes

@gcolvin gcolvin gcolvin approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinbenlv @eth-bot @gcolvin @abcoathup