Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Linter Scope #7199

Merged
merged 8 commits into from
Jun 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions EIPS/eip-7199.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
eip: 7199
title: Linter Scope
description: Relax the policy for updating EIP.
author: Zainan Victor Zhou (@xinbenlv)
discussions-to: https://ethereum-magicians.org/t/proposal-eipw-should-only-complain-about-changing-lines/14762
status: Draft
type: Meta
created: 2023-06-20
---

## Abstract

Currently in practice EIP linter tools (EIPW, for example) will block a Pull Request for lint errors even if that lint errors was not introduced in that Pull Request.
This EIP make it explicit that lint errors for untouched lines shall be considered ignoreable except for status change.

## Specification

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.

In an update to an EIP, A Pull Request SHOULD NOT be required to fix linter errors in untouched lines unless it's changing the Status of the EIP.

## Rationale

This policy allows micro contributions for anyone who just want to fix a typo or change a section of a section in a large EIP.

## Security Considerations

None

## Copyright

Copyright and related rights waived via [CC0](../LICENSE.md).