-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7685: remove requests from block body #8908
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment.
Co-authored-by: Mario Vega <[email protected]> Co-authored-by: lightclient <[email protected]>
@@ -70,7 +55,7 @@ Extend the header with a new 32 byte value `requests_hash`: | |||
def compute_requests_hash(list): | |||
return keccak256(rlp.encode([rlp.encode(req) for req in list])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Mikhail's comment in #591 description:
Use concatenation to compute the resulting list of all requests instead of RLP, i.e. do executionRequests = requests_00 || requests_01 || requests_02 instead of requests = RLP([requests_00, requests_01, requests_02]). And use the executionRequests in Engine API and in requestsHash computation, the latter can be as simple as requestsHash = executionRequests(requests)
It seems like this should also be updated to:
return keccak256(rlp.encode([rlp.encode(req) for req in list])) | |
return keccak256(b"".join(list)) |
Or something along the lines.
superseded by #8924 |
This PR removes the requests from the block body. This change is motivated by a simplification to the engine api: ethereum/execution-apis#591