[ShadCN] refactor(pages/learn): migrate to ShadCN #13569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
force-pushed
the
feat/learn-page-shadcn
branch
from
5a80d1d to
b3b59c9
Compare
TylerAPfledderer
changed the title
pettinarip
requested changes
Aug 7, 2024
There was a problem hiding this comment.
@TylerAPfledderer looks good. Would be nice if we could start using the recently migrated primitives, including the Image component that is in review (#13601).
TylerAPfledderer
force-pushed
the
feat/learn-page-shadcn
branch
from
7b7cd03 to
cf0f580
Compare
This was referenced Aug 9, 2024
pettinarip
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Nice job @TylerAPfledderer.
I've updated the branch with dev. Once the build finishes, I think we are ready to merge it.
pettinarip
approved these changes
Aug 13, 2024
This was referenced Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the
Learnpage to remove direct Chakra imports and use ShadCN components and Tailwind.Some areas are marked with a commented
TODOto address with future migrations.