[ShadCN] feat: create table component set with ShadCN #13708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
the
dependencies 📦
TylerAPfledderer
changed the title
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
reviewed
Sep 13, 2024
There was a problem hiding this comment.
@TylerAPfledderer this looks great, clean & simple.
I would prefer to replace the old table with this new one if possible. Do you think you can do it in this PR or we could also do it separately.
There was a problem hiding this comment.
This file should be outside the __stories__ folder
| const tableVariants = tv({ | ||
| slots: { | ||
| table: "w-full", | ||
| th: "text-start border-b-[1px] border-body text-body normal-case align-bottom p-4", |
There was a problem hiding this comment.
Suggested change
| th: "text-start border-b-[1px] border-body text-body normal-case align-bottom p-4", | |
| th: "text-start border-b border-body text-body normal-case align-bottom p-4", |
| @@ -0,0 +1,234 @@ | |||
| import * as React from "react" | |||
|
|
|||
| import InlineLink from "../../../../../tailwind/ui/Link" | |||
There was a problem hiding this comment.
should be import InlineLink from "@/components/Link"
TylerAPfledderer
force-pushed
the
feat/shadcn-tables
branch
from
4ed57b8 to
027f1aa
Compare
|
@pettinarip did a full replacement of the table component. So this new version is available to be checked for prod. |
pettinarip
approved these changes
Sep 16, 2024
nloureiro
approved these changes
Sep 16, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates the Table components using ShadCN.
Creates a separate story file until deemed ready to merge and be a part of the Chromatic snapshots.
Also introduces tailwind-variants which allows you to create slot variants: variant sets to pass to a multi-component (i.e.
Table,Tag, etc. that has many parts)tailwind-variantsto be used in place ofclass-variance-authority