[ShadCN] Migrate Select #13725
Merged
[ShadCN] Migrate Select #13725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies 📦
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Nice @TylerAPfledderer this looks cleeean ✨
I think this is ready to replace the old Select and complete the migration. Would you mind doing that in this PR? I could help with that as well.
|
@pettinarip I will move on to doing that switch. Thanks! |
|
@pettinarip updates have been pushed. Made changes to import for new |
pettinarip
approved these changes
Sep 11, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates
Selectcomponent to ShadCN/Tailwind.Maintains the api from
react-selectand introducestailwind-variantsto create the style variants.Not moving to the ShadCN
Selectas it would require additional logic to mimicreact-select, and should be addressed in a future PR.