accounts/usbwallet: fix ledger access for latest firmware and add Ledger Flex #31004
Conversation
mdehoog
changed the title
fjl
changed the title
| // Windows and Macos use UsageID matching, Linux uses Interface matching | ||
| if info.ProductID == id && (info.UsagePage == hub.usageID || info.Interface == hub.endpointID) { | ||
| if (info.ProductID == id || mmOnly == id) && (info.UsagePage == hub.usageID || info.Interface == hub.endpointID) { |
There was a problem hiding this comment.
This does not look right to me. Consider a future / non-compatible device, which identifies itself as 0x00aa.
mmOnly := 0x00aa & 0xff00 // 0x0000. The check mmOnly == id would match it as a Ledger Blue.
There was a problem hiding this comment.
I can't comment on if Ledger would release a product with an ID like this, but my understanding is that the 0x00** product IDs are legacy and new products would always follow the new MMII format.
An alternative might be to remove this product ID filtering altogether and just rely on the vendor ID lookup we're already doing.
There was a problem hiding this comment.
Removing the product id check would break support for legacy devices.
If they change the scheme (which they might, it's only allowing for 256 devices which they might get to eventually) we will have to store them in the table one by one, or deal with it when the next scheme comes into effect. Maybe they'll change the vendor id as well. No way to know.
The latest firmware for Ledger Nano S Plus now returns
0x5000for it's product ID, which doesn't match any of the product IDs enumerated inhub.go.This PR removes the assumption about the interfaces exposed, and simply checks the upper byte for a match.
Also adds support for the
0x0007/0x7000product ID (Ledger Flex).