Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 Recap #36

Merged
merged 6 commits into from
Oct 21, 2024
Merged

2024 Recap #36

merged 6 commits into from
Oct 21, 2024

Conversation

holgerd77
Copy link
Collaborator

@holgerd77 holgerd77 commented Oct 11, 2024

EF JavaScript team recap for 2024, roadmap document to follow (separate PR).

acolytec3
acolytec3 previously approved these changes Oct 11, 2024
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but left a few comments

roadmap/README.md Show resolved Hide resolved
roadmap/README.md Outdated Show resolved Hide resolved
roadmap/README.md Outdated Show resolved Hide resolved
- Verkle [devnets](https://github.com/ethpandaops/verkle-devnets) participation, stateless block execution, spec work
- EIP-6493 Stable Container [Prototyping](https://github.com/ethereumjs/ethereumjs-monorepo/pull/3452)

Since autumn 2024 we are able to [fill execution-spec-tests](https://github.com/ethereum/execution-spec-tests/pull/752), which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR (plus the t8ntool PR on our side ethereumjs/ethereumjs-monorepo#3603) when trying to fill fixtures (especially the 7702 ones) we also found errors in the tests themselves, thus this opens a great feedback loop with the testing team to verify the tests are correct. Also part of this feedback loop is a coverage test: for instance, when we find a new rule in 7702 which is clearly not implemented, but the test filler did not complain, this means that this rule is thus not tested in execution-spec-tests and should be added.

A side note could also be added that we have a small amount of PRs merged in EEST with new tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the summary, will put more emphasis on these kind of things in the roadmap itself (this here is only the 2024 recap, so very much just a side document).

@holgerd77
Copy link
Collaborator Author

Ok, thanks for the comments and reviews! Will merge this in and open a new PR for the roadmap itself! Nevertheless feel free to do additional comments here if necessary, then I'll incorporate in the upcoming PR!

@holgerd77 holgerd77 merged commit 82a1ffd into master Oct 21, 2024
1 check passed
@holgerd77 holgerd77 deleted the recap-2024-and-roadmap-2025 branch October 21, 2024 12:55
@holgerd77 holgerd77 mentioned this pull request Oct 21, 2024
@holgerd77 holgerd77 changed the title Roadmap 2025 / 2024 Recap 2024 Recap Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants