Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 Recap #36
2024 Recap #36
Changes from all commits
22f8bde
3ae82af
fb516b0
6903e68
8ae8484
d6b3951
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR (plus the t8ntool PR on our side ethereumjs/ethereumjs-monorepo#3603) when trying to fill fixtures (especially the 7702 ones) we also found errors in the tests themselves, thus this opens a great feedback loop with the testing team to verify the tests are correct. Also part of this feedback loop is a coverage test: for instance, when we find a new rule in 7702 which is clearly not implemented, but the test filler did not complain, this means that this rule is thus not tested in execution-spec-tests and should be added.
A side note could also be added that we have a small amount of PRs merged in EEST with new tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the summary, will put more emphasis on these kind of things in the roadmap itself (this here is only the 2024 recap, so very much just a side document).
This file was deleted.
This file was deleted.