Purge using namespace from libsolidity/lsp and parsing #14493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-matic
force-pushed
the
purge-using-namespace-from-libsolidity-lsp-parsing
branch
from
364a446
to
bc5e267
Compare
cameel
previously approved these changes
Aug 16, 2023
nikola-matic
force-pushed
the
purge-using-namespace-from-libsolidity-lsp-parsing
branch
from
bc5e267
to
3e9a52d
Compare
cameel
previously approved these changes
Aug 16, 2023
nikola-matic
force-pushed
the
purge-using-namespace-from-libsolidity-lsp-parsing
branch
from
3e9a52d
to
f344dc1
Compare
cameel
approved these changes
Aug 16, 2023
nikola-matic
deleted the
purge-using-namespace-from-libsolidity-lsp-parsing
branch
cameel
reviewed
Aug 16, 2023
Comment on lines
1246
to
1252
| tie(keyName, keyNameLocation) = expectIdentifierWithLocation(); | ||
| expectToken(Token::DoubleArrow); | ||
| ASTPointer<TypeName> valueType = parseTypeName(); | ||
| ASTPointer<ASTString> valueName = make_shared<ASTString>(""); | ||
| ASTPointer<ASTString> valueName = std::make_shared<ASTString>(""); | ||
| SourceLocation valueNameLocation{}; | ||
| if (m_scanner->currentToken() == Token::Identifier) | ||
| tie(valueName, valueNameLocation) = expectIdentifierWithLocation(); |
There was a problem hiding this comment.
I'm rebasing my PRs on top of this now and just noticed that there are quite a few instances of std::tie() without std:: in this file. How does that even compile? Do we have a custom definition of tie() somewhere? Or maybe using namespace std in one of the headers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #14403