Separate type context pass in new analysis #14721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using the same name causes syntax ambiguities. It's also not allowed for user-defined classes and types.
Exclude list for AST JSON tests Fix type inference shellcheck failure Disable shellcheck SC2086
…tration-pass Separate type class registration pass in experimental analysis
Defining built-ins in experimental analysis
…nction and Itself
…riant rather than on the type variable
Assorted bugfixes for new analysis
…sues-to-make-tests-pass Patch codegen issues enough to make tests pass in experimental analysis
cameel
force-pushed
the
new-analysis-forall
branch
2 times, most recently
from
fdb1ceb
to
1a2b059
Compare
cameel
force-pushed
the
new-analysis-forall
branch
from
1a2b059
to
4ea8712
Compare
cameel
force-pushed
the
new-analysis-forall
branch
from
4ea8712
to
0426c6d
Compare
github-actions
bot
added
the
stale
cameel
removed
the
stale
github-actions
bot
added
the
stale
cameel
removed
the
stale
cameel
force-pushed
the
new-analysis-forall
branch
from
0426c6d
to
dd2197b
Compare
github-actions
bot
added
the
stale
cameel
removed
the
stale
cameel
force-pushed
the
new-analysis-forall
branch
from
dd2197b
to
ec1fc8a
Compare
cameel
force-pushed
the
new-analysis-forall
branch
2 times, most recently
from
d04efe7
to
cd52e5a
Compare
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #14668.
Replaces #14578.
This PR extracts type and sort context analysis from
TypeInference. All the types that are given explicitly and do not have to be inferred are stored in annotations in that separate pass. This will enable let us extract processing of type class bodies fromTypeInferenceinto a separate pass in the next step (we could also just put it in the new pass).The code already passes tests, but needs some serious cleanup before it can be considered stable.
TypeInferenceand duplicates its helpers, definitions and even error codes.typein type context to something else to avoid confusion.members,operatorsandtypeClassFunctionsto the new pass.