EVM: Generic BN254 (alt_BN128) Interface for Precompiles / Use @noble/curves By Default #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cheme started with BLS
…assing instead of separate constructor parameter
… createEVM() method
…rface, encapsule string conversions for rustbn
…tils to precompile utils
…r right-pad) as stated in EIP
…ew --bn254 option for VM test runners (default: rustbn.js)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3449 by using native JS implementations for addition, multiplication and pairing from https://github.com/paulmillr/noble-curves, where pairing functionality just has been added (not yet released).
This PR follows the path of the native BLS integration from #3471 and adds a generic interface which allows to replace the native version with the WASM version or alternatively a custom implementation.
WIP