Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Generic BN254 (alt_BN128) Interface for Precompiles / Use @noble/curves By Default #3564

Merged
merged 32 commits into from
Aug 8, 2024
Merged

EVM: Generic BN254 (alt_BN128) Interface for Precompiles / Use @noble/curves By Default #3564

merged 32 commits into from
Aug 8, 2024

Commits on Aug 6, 2024

  1. Rename BN254 (alt_BN128) interface to match the more generic naming s… 

    …cheme started with BLS
    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    47db32f View commit details
    Browse the repository at this point in the history

  2. Add bn254 EVM constructor option, use option for existing rustbn.js p… 

    …assing instead of separate constructor parameter
    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    2cb20a3 View commit details
    Browse the repository at this point in the history

  3. Add a thin wrapper interface around pure rustbn, use interface within… 

    … createEVM() method
    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    59766c9 View commit details
    Browse the repository at this point in the history

  4. Naming adjustments

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    fb2f4a7 View commit details
    Browse the repository at this point in the history

  5. Switch over to use Uint8Array as input and output values for the inte… 

    …rface, encapsule string conversions for rustbn
    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ef4e8dc View commit details
    Browse the repository at this point in the history

  6. One-time WASM initialization fix

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cfe2f32 View commit details
    Browse the repository at this point in the history

  7. Add dummy Noble interface

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1743872 View commit details
    Browse the repository at this point in the history

  8. Add custom (temporary) @noble/curves build to EVM package.json

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    978335f View commit details
    Browse the repository at this point in the history

  9. Rebuild package-lock.json

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ec29aaf View commit details
    Browse the repository at this point in the history

  10. Temporary fix for conflicting @noble/curves versions

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b7fdd49 View commit details
    Browse the repository at this point in the history

  11. Integrate Noble usage for multiplication

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4e0be50 View commit details
    Browse the repository at this point in the history

  12. Add generic equalityLengthCheck, moduloLengthCheck methods from BLS u… 

    …tils to precompile utils
    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d61aa47 View commit details
    Browse the repository at this point in the history

  13. Fix test

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    610852b View commit details
    Browse the repository at this point in the history

  14. Minor

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    69bca4c View commit details
    Browse the repository at this point in the history

  15. Fixes

    @holgerd77
    holgerd77 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d324623 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Add validity assertion for G1 point

    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ef7ab69 View commit details
    Browse the repository at this point in the history

  2. Replace equality length check with byte length correction (chop off o… 

    …r right-pad) as stated in EIP
    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    484a859 View commit details
    Browse the repository at this point in the history

  3. Fixes

    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    69f387e View commit details
    Browse the repository at this point in the history

  4. Add BN254 add implementation

    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    09bbab2 View commit details
    Browse the repository at this point in the history

  5. Add additional pairing modulo length check since not safe to rely on … 

    …implementation
    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    29faa84 View commit details
    Browse the repository at this point in the history

  6. Some basic alignment

    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ea1780d View commit details
    Browse the repository at this point in the history

  7. First try on pairing (not working yet)

    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ce4eca5 View commit details
    Browse the repository at this point in the history

  8. First pairing tests passing

    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    50919fc View commit details
    Browse the repository at this point in the history

  9. Fixes

    @holgerd77
    holgerd77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8e41321 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into evm-bn254-precompile-native-js

    @holgerd77
    holgerd77 authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    042765c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Update @noble/curves to final v1.5.0 release

    @holgerd77
    holgerd77 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d978474 View commit details
    Browse the repository at this point in the history

  2. Rebuild package-lock.json

    @holgerd77
    holgerd77 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cfe48cf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into evm-bn254-precompile-native-js

    @holgerd77
    holgerd77 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    def936d View commit details
    Browse the repository at this point in the history

  4. Use plain Noble BN254 by default, clean-up, interface type exports, n… 

    …ew --bn254 option for VM test runners (default: rustbn.js)
    @holgerd77
    holgerd77 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c187705 View commit details
    Browse the repository at this point in the history

  5. Move rustbn-wasm dependency over to EVM dev dependencies, add to clie… 

    …nt dependencies
    @holgerd77
    holgerd77 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f35850c View commit details
    Browse the repository at this point in the history

  6. Rebuild package-lock.json

    @holgerd77
    holgerd77 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    33cc3e9 View commit details
    Browse the repository at this point in the history

  7. Integrate in client

    @holgerd77
    holgerd77 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3b3e324 View commit details
    Browse the repository at this point in the history