Write json fixture test groundwork #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pipermerriam ran into some nasty git issues with the old branch, but this is an exact duplicate, adjusted for ethan's pr. If there's anything else that needs to be added, holler. |
|
will take a look at it tomorrow. |
njgheorghita
force-pushed
the
json-fixture-tests
branch
from
bc945d2
to
fdc28d6
Compare
njgheorghita
force-pushed
the
json-fixture-tests
branch
2 times, most recently
from
10806cc
to
afe5016
Compare
njgheorghita
force-pushed
the
json-fixture-tests
branch
from
afe5016
to
87bded9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pipermerriam, I took a shot at writing the fixture tests. I jacked a lot of the code / design from py-evm. Not sure if that was the best way to approach (adding unnecessary complexity)? Should I go ahead and create a json fixture test file for all the different kinds of packages? What other kinds of things belong in the fixture file? Right now it's really only testing that the
Packageobject has certain attributes. Feedback on what's good / bad / needs changing would be really helpful, thanks!What was wrong?
Project needs standardized json fixture tests to allow other py-ethpm implementations to develop against the same spec.
How was it fixed?
Started laying the groundwork for fixture tests.
Cute Animal Picture
closes #9