Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run configlet lint manually in check_formatting.dart #301

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Don't run configlet lint manually in check_formatting.dart #301

merged 3 commits into from
Feb 18, 2021

Conversation

devkabiir
Copy link
Contributor

Closes #296

@devkabiir
Copy link
Contributor Author

devkabiir commented Feb 18, 2021 •
edited
Loading

@exercism/maintainers-admin
Is configlet fmt . still supported?, Otherwise I'd need to update that as well in the

dart/bin/presubmit.dart

Line 9 in 306aaaf

await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']);


https://github.com/exercism/dart/pull/298/checks#step:5:6 (3 hours ago) Shows that --track-id is not a supported option
https://github.com/exercism/dart/runs/1927244439?check_suite_focus=true#step:5:6 (20 minutes ago) Shows it's working, but config.json is indeed ill-formatted.
This PR disables it altogether because we have Configlet CI workflow. And Test workflow can be executed independent of configlet changes

@devkabiir devkabiir marked this pull request as ready for review February 18, 2021 13:29
@iHiD iHiD requested a review from ErikSchierboom February 18, 2021 14:10
@ErikSchierboom
Copy link
Member

configlet fmt is not supported at the moment. Maybe later

@devkabiir
🐛 (exercises/concepts) Add stub content to dart files
7fbb0e1 
This is to allow dart formatting checks to pass in CI
@devkabiir devkabiir mentioned this pull request Feb 18, 2021
Open
@devkabiir devkabiir merged commit 02b330f into main Feb 18, 2021
@devkabiir devkabiir deleted the devkabiir-patch-2 branch February 18, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update scripts based on recent configlet changes
2 participants
@devkabiir @ErikSchierboom