Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run configlet lint manually in check_formatting.dart #301

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Don't run configlet lint manually in check_formatting.dart #301

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
306aaaf
Don't run configlet lint manually in check_formatting.dart
devkabiir Feb 18, 2021
7fbb0e1
🐛 (exercises/concepts) Add stub content to dart files
devkabiir Feb 18, 2021
0f7c404
🚧 (presubmit) Temporarily disable `configlet fmt`
devkabiir Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions bin/check_formatting.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,6 @@ Future main() async {
final CommonUtils utils = CommonUtils();
int errorCode = 0;

if (await utils.fetchConfiglet() == 0) {
print('Checking config.json formatting...');
errorCode = await utils.runCmdIfExecutable('bin/configlet', ['lint', '--track-id', 'dart', '.']);

if (errorCode != 0) {
print('Checking config.json formatting failed!!');
await utils.terminate();
throw StateError('Formatting failed.');
}
}

print('Checking all Dart files formatting...');
errorCode = await utils
.runCmd('pub', ['run', 'dart_style:format', '-i', '0', '-l', '120', '-n', '--set-exit-if-changed', '.']);
Expand Down