Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test updated for Freelancer Rates: Corrects a invalid test #1378

Closed
wants to merge 1 commit into from
Closed

Test updated for Freelancer Rates: Corrects a invalid test #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/concept/freelancer-rates/test/freelancer_rates_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ defmodule FreelancerRatesTest do
@tag task_id: 4
test "it applies the discount" do
# 1.25
assert FreelancerRates.days_in_budget(480, 60, 20) == 1.2
assert FreelancerRates.days_in_budget(480, 60, 20) == 0.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find an issue in this test.

budget = 480, hourly_rate = 60, discount = 20%
daily_rate = 8 * 60 = 480
daily_rate_with_discount = 480 - 20% = 384
days_in_budget = 480 / 384 = 1.25 (rounded to 1.2)

Can you point to the problem?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, my bad

end
end
end