Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites for practice exercises #1462

Merged

Conversation

TomPradat
Copy link
Contributor

Related to #983

@github-actions
Copy link
Contributor

Dear TomPradat

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@TomPradat
Copy link
Contributor Author

Could i have a hacktoberfest-accepted label on this PR please ? :)

@TomPradat TomPradat marked this pull request as ready for review October 24, 2021 18:58
@junedev junedev added the hacktoberfest-accepted Opt-in to hacktoberfest label Oct 24, 2021
Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this task again. I left some suggestions.

config.json Outdated
@@ -526,7 +526,7 @@
"name": "Collatz Conjecture",
"uuid": "b8dacb3a-51d0-4da7-a6d2-aa29867e2b8c",
"practices": [],
"prerequisites": [],
"prerequisites": ["while-loops", "conditionals", "errors"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add two more here:

Suggested change
"prerequisites": ["while-loops", "conditionals", "errors"],
"prerequisites": ["arithmetic-operators", "comparison", "while-loops", "conditionals", "errors"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.json Outdated
@@ -542,7 +542,7 @@
"name": "Triangle",
"uuid": "ed3ca73a-a0f0-46b8-8013-8b6d20758c8f",
"practices": [],
"prerequisites": [],
"prerequisites": ["numbers", "arithmetic-operators", "classes"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no arithmetic operator needed besides + so I would recommend using comparison instead as there are lots of === etc needed. Additionally, the operators && and || are covered in booleans so I would add that.

Suggested change
"prerequisites": ["numbers", "arithmetic-operators", "classes"],
"prerequisites": ["numbers", "booleans", "comparison", "classes"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat ! I missed the comparison concept too 😕 . And booleans make sense to me too 👍

Copy link
Contributor Author

@TomPradat TomPradat Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.json Outdated
@@ -576,7 +581,7 @@
"name": "Etl",
"uuid": "db16804b-0f63-445d-8beb-99e0f7218d66",
"practices": [],
"prerequisites": [],
"prerequisites": ["objects", "for-loops", "arrays", "strings"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forEach and for...of are taught in the concept array-loops. I would put that one instead of for-loops. The student can still decide to use for loops instead but it makes sense for them to know array loops before working on this exercise. If you disagree it can also stay as is.

Suggested change
"prerequisites": ["objects", "for-loops", "arrays", "strings"],
"prerequisites": ["objects", "array-loops", "arrays", "strings"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that concept, I agree 💯

Copy link
Contributor Author

@TomPradat TomPradat Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junedev junedev added the x:size/small Small amount of work label Oct 25, 2021
@junedev junedev merged commit 082da89 into exercism:main Oct 25, 2021
@TomPradat TomPradat deleted the feature/TP/practice-exercises-prerequisites branch October 25, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants