-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prerequisites for practice exercises #1462
Add prerequisites for practice exercises #1462
Conversation
Dear TomPradatThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
Could i have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking up this task again. I left some suggestions.
config.json
Outdated
@@ -526,7 +526,7 @@ | |||
"name": "Collatz Conjecture", | |||
"uuid": "b8dacb3a-51d0-4da7-a6d2-aa29867e2b8c", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["while-loops", "conditionals", "errors"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add two more here:
"prerequisites": ["while-loops", "conditionals", "errors"], | |
"prerequisites": ["arithmetic-operators", "comparison", "while-loops", "conditionals", "errors"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config.json
Outdated
@@ -542,7 +542,7 @@ | |||
"name": "Triangle", | |||
"uuid": "ed3ca73a-a0f0-46b8-8013-8b6d20758c8f", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["numbers", "arithmetic-operators", "classes"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no arithmetic operator needed besides +
so I would recommend using comparison
instead as there are lots of ===
etc needed. Additionally, the operators && and || are covered in booleans
so I would add that.
"prerequisites": ["numbers", "arithmetic-operators", "classes"], | |
"prerequisites": ["numbers", "booleans", "comparison", "classes"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat ! I missed the comparison concept too 😕 . And booleans
make sense to me too 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config.json
Outdated
@@ -576,7 +581,7 @@ | |||
"name": "Etl", | |||
"uuid": "db16804b-0f63-445d-8beb-99e0f7218d66", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["objects", "for-loops", "arrays", "strings"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forEach
and for...of
are taught in the concept array-loops
. I would put that one instead of for-loops. The student can still decide to use for loops instead but it makes sense for them to know array loops before working on this exercise. If you disagree it can also stay as is.
"prerequisites": ["objects", "for-loops", "arrays", "strings"], | |
"prerequisites": ["objects", "array-loops", "arrays", "strings"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that concept, I agree 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #983