Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites for practice exercises #1462

Merged
merged 7 commits into from
Oct 25, 2021
Merged

Add prerequisites for practice exercises #1462

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09cb454
Add prerequisites for collatz-conjecture exercise
TomPradat Oct 24, 2021
4248815
Add prerequisites for exercise triangle
TomPradat Oct 24, 2021
d13d786
Add prerequisites for exercise 'clock'
TomPradat Oct 24, 2021
be7131a
Add prerequisites for exercise 'etl'
TomPradat Oct 24, 2021
2a0aa5d
fixup! Add prerequisites for exercise 'etl'
TomPradat Oct 25, 2021
d12bc00
fixup! Add prerequisites for exercise triangle
TomPradat Oct 25, 2021
b8bc2b3
fixup! Add prerequisites for collatz-conjecture exercise
TomPradat Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@
"name": "Collatz Conjecture",
"uuid": "b8dacb3a-51d0-4da7-a6d2-aa29867e2b8c",
"practices": [],
"prerequisites": [],
"prerequisites": ["while-loops", "conditionals", "errors"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add two more here:

Suggested change
"prerequisites": ["while-loops", "conditionals", "errors"],
"prerequisites": ["arithmetic-operators", "comparison", "while-loops", "conditionals", "errors"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b8bc2b3

"difficulty": 3,
"topics": [
"conditionals",
Expand All @@ -542,7 +542,7 @@
"name": "Triangle",
"uuid": "ed3ca73a-a0f0-46b8-8013-8b6d20758c8f",
"practices": [],
"prerequisites": [],
"prerequisites": ["numbers", "arithmetic-operators", "classes"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no arithmetic operator needed besides + so I would recommend using comparison instead as there are lots of === etc needed. Additionally, the operators && and || are covered in booleans so I would add that.

Suggested change
"prerequisites": ["numbers", "arithmetic-operators", "classes"],
"prerequisites": ["numbers", "booleans", "comparison", "classes"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat ! I missed the comparison concept too 😕 . And booleans make sense to me too 👍

Copy link
Contributor Author

@TomPradat TomPradat Oct 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d12bc00

"difficulty": 3,
"topics": ["conditionals", "loops", "exception_handling", "integers"]
},
Expand All @@ -551,7 +551,12 @@
"name": "Clock",
"uuid": "4e0e2c30-be33-49b6-b196-213888a93a0c",
"practices": [],
"prerequisites": [],
"prerequisites": [
"arithmetic-operators",
"numbers",
"classes",
"strings"
],
"difficulty": 5,
"topics": ["dates", "globalization", "time"]
},
Expand All @@ -576,7 +581,7 @@
"name": "Etl",
"uuid": "db16804b-0f63-445d-8beb-99e0f7218d66",
"practices": [],
"prerequisites": [],
"prerequisites": ["objects", "for-loops", "arrays", "strings"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forEach and for...of are taught in the concept array-loops. I would put that one instead of for-loops. The student can still decide to use for loops instead but it makes sense for them to know array loops before working on this exercise. If you disagree it can also stay as is.

Suggested change
"prerequisites": ["objects", "for-loops", "arrays", "strings"],
"prerequisites": ["objects", "array-loops", "arrays", "strings"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that concept, I agree 💯

Copy link
Contributor Author

@TomPradat TomPradat Oct 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2a0aa5d

"difficulty": 2,
"topics": ["loops", "integers", "maps", "transforming"]
},
Expand Down