Fix/save attachment #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al alignment for icons of the field in Destination folder block (.currentFolder)
pnedonosko
suggested changes
Dec 23, 2019
| <properties-param> | ||
| <name>link-configuration</name> | ||
| <property name="server-host" value="${outlook.exo.server.host:}" /> | ||
| <property name="server-schema" value="${outlook.exo.server.schema:http}" /> | ||
| <property name="server-host" value="${outlook.exo.server.host:nik.exoplatform.com.ua}" /> |
There was a problem hiding this comment.
Like this should not be committed in generally used code
| </properties-param> | ||
| </init-params --> |
There was a problem hiding this comment.
Revert this change to commented block - it should work without it.
| @@ -823,10 +828,14 @@ textarea[name='activityTitle'], textarea[name='comment'] { | |||
| } | |||
|
|
|||
| .connections { | |||
| position: relative; | |||
| transition: 2s; | |||
| position: relative; | |||
There was a problem hiding this comment.
Avoid reformatting where fixing one or two lines only. This mislead when need merge or backport to stable codebase.
pnedonosko
suggested changes
Dec 23, 2019
| @@ -58,7 +58,7 @@ | |||
| <pathAddDescription>Create a new folder</pathAddDescription> | |||
| <pathOpenDescription>Open in new window</pathOpenDescription> | |||
| <savingAttachment>Saving your files...</savingAttachment> | |||
| <savedAttachment>Your files were successfully saved</savedAttachment> | |||
| <savedAttachment>Your files were successfully saved in</savedAttachment> | |||
There was a problem hiding this comment.
We already have i18n string for in text - <in>in</in>, is it not used? This text should not be changed and if but not this way to fix it.
There was a problem hiding this comment.
<in>in</in> isn't used anywhere (about savedAttachment context). That's why the "in" added here.
…he max block height - 100vh) and related trial message block (raised by 35 px).
…sync; corrected page content edit for Convert -> to Wiki and Convert -> to Discussion; refactored code
…he message body block (content))
…avoid scrolling with other elements)
…en text tags added, blocks aligement (contacts) and vertical scroll bar corrected)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.