Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/save attachment #19

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Fix/save attachment #19

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f0f652b
Added local configuration
NickEngineer Dec 19, 2019
6ea016d
Fixed Outlook Save Attachments js error (missed var) and added vertic…
NickEngineer Dec 20, 2019
5c2a616
Cleared local configuration
NickEngineer Dec 23, 2019
b67be48
Avoided style reformatting (outlook.css)
NickEngineer Dec 23, 2019
407f732
Fixed Saved Attachment localization (added 'in')
NickEngineer Dec 23, 2019
0b60b72
Fixed templates result status block alignment
NickEngineer Dec 26, 2019
6746cc3
Corrected brandBar position (defined the bottom position by setting t…
NickEngineer Dec 27, 2019
602b655
Commented the link for Office.context.mailbox.item.addFileAttachmentA…
NickEngineer Dec 31, 2019
27fee3c
Added margin for .messageEditorIframe body (corrected intervals for t…
NickEngineer Dec 31, 2019
9b21033
Corrected outlook-brand-bar position (set fixed position in order to …
NickEngineer Jan 2, 2020
dfc9b63
Added default images for users in the People menu
NickEngineer Jan 3, 2020
18811b2
Corrected latest activities displaying (the date and title displaying)
NickEngineer Jan 3, 2020
ce4a7ec
Corrected eXo Platform -> People (user default icons changed, forgott…
NickEngineer Jan 3, 2020
342e426
Added getRelationshipsByStatus limit: 50
NickEngineer Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webapp/src/main/resources/locale/outlook/Outlook.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<pathAddDescription>Create a new folder</pathAddDescription>
<pathOpenDescription>Open in new window</pathOpenDescription>
<savingAttachment>Saving your files...</savingAttachment>
<savedAttachment>Your files were successfully saved</savedAttachment>
<savedAttachment>Your files were successfully saved in</savedAttachment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have i18n string for in text - <in>in</in>, is it not used? This text should not be changed and if but not this way to fix it.

Copy link
Author

@NickEngineer NickEngineer Dec 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<in>in</in> isn't used anywhere (about savedAttachment context). That's why the "in" added here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<savedClickToOpen>Click a file in the list below to open it inside the intranet</savedClickToOpen>
<addingNewFolder>Adding new folder</addingNewFolder>
<enterFolderNameAndCreate>Provide a name for this new folder and then click "Add".</enterFolderNameAndCreate>
Expand Down
2 changes: 1 addition & 1 deletion webapp/src/main/webapp/js/outlook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ require(["SHARED/jquery", "SHARED/outlookFabricUI", "SHARED/outlookJqueryUI", "S

var item = Office.context.mailbox.item;
if (item.attachments.length > 0) {
for (i = 0; i < item.attachments.length; i++) {
for (var i = 0; i < item.attachments.length; i++) {
var att = item.attachments[i];
var $li = $("<li class='ms-ListItem is-selectable'><span class='ms-ListItem-primaryText'>"
+ att.name + "</span><span class='ms-ListItem-metaText attachmentSize'>" //
Expand Down
4 changes: 4 additions & 0 deletions webapp/src/main/webapp/skin/outlook.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,7 @@ textarea[name='activityTitle'], textarea[name='comment'] {
.compose-Persona {
margin: 10px 15px 10px 0;
}

.currentFolder .pathControls .ms-ListItem-action .ms-Icon {
vertical-align: middle;
}