Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump send to 0.19 #176

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

tommasini
Copy link

@tommasini tommasini commented Sep 10, 2024

Bumping send to 0.19 to solve GHSA-m6fv-jmcg-4jfg

Solves: #175

@jayvdb
Copy link

jayvdb commented Sep 11, 2024

ping @UlisesGascon & @wesleytodd

Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ 🚀

Copy link

@chrysloi chrysloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tommasini

@tommasini
Copy link
Author

@UlisesGascon It's unclear to me why node v8 and v9 unit tests are failing looking at the github CI. Taking a look and running it locally it seems that the 92 tests are passing! Do you have a hint of what's happening?

Copy link

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 8/9 was failing same target branch 1.x similarly couple yrs/days ago

so unrelated to our bump ^ looks good to merge

@wesleytodd wesleytodd merged commit 4263f49 into expressjs:1.x Sep 11, 2024
19 of 21 checks passed
@s100
Copy link

s100 commented Sep 12, 2024

This change went into [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants