Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Heart works with Node.js version 21 #201

Merged
merged 5 commits into from
Jan 14, 2024
Merged

feat: make Heart works with Node.js version 21 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a9eac1
ci: run tests with the shiny new Node.js version 21
bgatellier Oct 18, 2023
5b644b1
chore: allows Rush to be run on Node.js 21
bgatellier Oct 18, 2023
d9b969e
feat: allows Node.js 21
bgatellier Oct 18, 2023
c98a188
docs: add changelogs
bgatellier Oct 18, 2023
c295b80
ci: use latest checkout action
bgatellier Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
reports_path: ${{ steps.list_reports_path.outputs.reports_path }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
shell: bash

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 2

Expand Down Expand Up @@ -44,10 +44,10 @@ jobs:
shell: bash
strategy:
matrix:
node_version: [18, 19, 20]
node_version: [18, 19, 20, 21]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
contents: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 2
ref: ${{ env.SOURCE_BRANCH }}
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
pull-requests: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 2
ref: ${{ env.SOURCE_BRANCH }}
Expand Down
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-api/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-api",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-api"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-cli/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-cli",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-cli"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-common/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-common",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-common"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-greenit/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-greenit",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-greenit"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-lighthouse/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-lighthouse",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-lighthouse"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-mysql/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-mysql",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-mysql"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-observatory/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-observatory",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-observatory"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-slack/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-slack",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-slack"
}
10 changes: 10 additions & 0 deletions common/changes/@fabernovel/heart-ssllabs-server/ci-test-with-node-21_2023-10-18-14-48.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-ssllabs-server",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-ssllabs-server"
}
2 changes: 1 addition & 1 deletion modules/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "api",
Expand Down
2 changes: 1 addition & 1 deletion modules/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@
"typescript": "^5.3.3"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
}
}
2 changes: 1 addition & 1 deletion modules/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@
"typescript": "^5.3.3"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
}
}
2 changes: 1 addition & 1 deletion modules/greenit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "greenit",
Expand Down
2 changes: 1 addition & 1 deletion modules/lighthouse/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "lighthouse",
Expand Down
2 changes: 1 addition & 1 deletion modules/mysql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "mysql",
Expand Down
2 changes: 1 addition & 1 deletion modules/observatory/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "observatory",
Expand Down
2 changes: 1 addition & 1 deletion modules/slack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "slack",
Expand Down
2 changes: 1 addition & 1 deletion modules/ssllabs-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "ssllabs-server",
Expand Down
2 changes: 1 addition & 1 deletion modules/tpl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "tpl",
Expand Down
2 changes: 1 addition & 1 deletion rush.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
* Specify a SemVer range to ensure developers use a NodeJS version that is appropriate
* for your repo.
*/
"nodeSupportedVersionRange": ">=18 <21",
"nodeSupportedVersionRange": ">=18 <22",

/**
* If you would like the version specifiers for your dependencies to be consistent, then
Expand Down