Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Heart works with Node.js version 21 #201

Merged
merged 5 commits into from
Jan 14, 2024
Merged

feat: make Heart works with Node.js version 21 #201

merged 5 commits into from
Jan 14, 2024

Conversation

bgatellier
Copy link
Contributor

@bgatellier bgatellier commented Oct 18, 2023 •
edited
Loading

  • Upgrade Rush with a compatible version (no issue about this ATM: 2023-10-18)
  • Update rush.json for versions range
  • Update package.json engines.node versions range

Closes #202

@bgatellier bgatellier added enhancement New feature or request ci/cd labels Oct 18, 2023
@bgatellier bgatellier self-assigned this Oct 18, 2023
@bgatellier bgatellier changed the title ci: run tests with the shiny new Node.js version 21 feat: make the Heart works with the shiny new Node.js version 21 Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad0ff1c) 33.70% compared to head (c295b80) 33.70%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   33.70%   33.70%           
=======================================
  Files          75       75           
  Lines        2789     2789           
  Branches      159      159           
=======================================
  Hits          940      940           
  Misses       1690     1690           
  Partials      159      159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgatellier bgatellier changed the title feat: make the Heart works with the shiny new Node.js version 21 feat: make Heart works with the shiny new Node.js version 21 Oct 18, 2023
@bgatellier bgatellier changed the title feat: make Heart works with the shiny new Node.js version 21 feat: make Heart works with Node.js version 21 Oct 18, 2023
@bgatellier bgatellier marked this pull request as draft October 18, 2023 17:48
@bgatellier bgatellier marked this pull request as ready for review January 14, 2024 14:46
@bgatellier bgatellier merged commit 14cfe3f into main Jan 14, 2024
9 checks passed
@bgatellier bgatellier deleted the ci/test-with-node-21 branch January 14, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgatellier bgatellier

Labels
ci/cd enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the packages work with Node.js 21
1 participant
@bgatellier