Get rid of ParamBasedTestProblemRunner #2964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64865707 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 25, 2024
Summary: See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Reviewed By: Balandat Differential Revision: D64865707
esantorella
force-pushed
the
export-D64865707
branch
from
239ade4
to
a80ff09
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64865707 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
========================================
Coverage 95.59% 95.59%
========================================
Files 487 486 -1
Lines 49108 48991 -117
========================================
- Hits 46943 46835 -108
+ Misses 2165 2156 -9 ☔ View full report in Codecov by Sentry. |
esantorella
force-pushed
the
export-D64865707
branch
from
a80ff09
to
5a483e6
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 28, 2024
Summary: See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Reviewed By: Balandat Differential Revision: D64865707
|
This pull request was exported from Phabricator. Differential Revision: D64865707 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 28, 2024
Summary: Pull Request resolved: facebook#2964 See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Differential Revision: D64865707 Reviewed By: Balandat
esantorella
force-pushed
the
export-D64865707
branch
from
5a483e6
to
cef39ef
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 29, 2024
Summary: See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Reviewed By: Balandat Differential Revision: D64865707
|
This pull request was exported from Phabricator. Differential Revision: D64865707 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64865707 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 29, 2024
Summary: Pull Request resolved: facebook#2964 See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Reviewed By: Balandat Differential Revision: D64865707
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 29, 2024
Summary: See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Reviewed By: Balandat Differential Revision: D64865707
esantorella
force-pushed
the
export-D64865707
branch
2 times, most recently
from
86f7e3d
to
91b9372
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64865707 |
Summary: Context: * `SurrogateRunner` and `SurrogateBenchmarkProblem` are unused as of D64855010. See that diff for further context. Changes in this diff: * Remove `SurrogateRunner` * Remove `SurrogateBenchmarkProblem` * Remove corresponding tests (all functionality is covered by new tests, e.g. for `SurrogateTestFunction`) Reviewed By: Balandat Differential Revision: D65139431
Summary: See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Reviewed By: Balandat Differential Revision: D64865707
esantorella
force-pushed
the
export-D64865707
branch
from
91b9372
to
36de103
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64865707 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 30, 2024
Summary: Pull Request resolved: facebook#2964 See previous diff for context. **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring. This diff: * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner` * Removes `ParamBasedTestProblemRunner` * Updates call sites * Removes some `assert_is_instance` checks Differential Revision: D64865707 Reviewed By: Balandat
|
This pull request has been merged in c40f103. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See previous diff for context.
NOTE TO REVIEWERS: The only interesting changes are in
runners/base.pyandrunners/botorch_test.py. And it is basically a cut-and-paste job, withBenchmarkRunnernow having the functionality of the oldParamBasedTestProblemRunner. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring.This diff:
runners.botorch_test.ParamBasedTestProblemRunnerintorunners.base.BenchmarkRunnerParamBasedTestProblemRunnerassert_is_instancechecksDifferential Revision: D64865707