Commits on Oct 30, 2024

1. Get rid of SurrogateRunner and SurrogateBenchmarkProblem (facebook#2988) …

   Summary:
   
   Context:
   * `SurrogateRunner` and `SurrogateBenchmarkProblem` are unused as of D64855010. See that diff for further context.
   
   Changes in this diff:
   * Remove `SurrogateRunner`
   * Remove `SurrogateBenchmarkProblem`
   * Remove corresponding tests (all functionality is covered by new tests, e.g. for `SurrogateTestFunction`)
   
   Reviewed By: Balandat
   
   Differential Revision: D65139431

   

   esantorella authored and facebook-github-bot committed Oct 30, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for eb95324
   • Browse repository at this point

   Copy the full SHA

   eb95324 View commit details

   Browse the repository at this point in the history

2. Get rid of ParamBasedTestProblemRunner (facebook#2964) …

   Summary:
   
   See previous diff for context.
   
   **NOTE TO REVIEWERS**: The only interesting changes are in `runners/base.py` and `runners/botorch_test.py`, and updating registries. And it is basically a cut-and-paste job, with `BenchmarkRunner` now having the functionality of the old `ParamBasedTestProblemRunner`. Sorry this is so large! This can't be easily broken up without creating a circular import issue. I can find a way to make smaller diffs if need be, but it would require more refactoring.
   
   This diff:
   * Adds functionality from `runners.botorch_test.ParamBasedTestProblemRunner` into `runners.base.BenchmarkRunner`
   * Removes `ParamBasedTestProblemRunner`
   * Updates call sites
   * Removes some `assert_is_instance` checks
   
   Reviewed By: Balandat
   
   Differential Revision: D64865707

   

   esantorella authored and facebook-github-bot committed Oct 30, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 36de103
   • Browse repository at this point

   Copy the full SHA

   36de103 View commit details

   Browse the repository at this point in the history