Paramatized rust_static_library to enable CXX support #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D50772544 |
This was referenced Oct 29, 2023
jdelliot
pushed a commit
to jdelliot/sapling
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/wangle
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/edencommon
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/rust-shed
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/watchman
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
This was referenced Oct 29, 2023
jdelliot
pushed a commit
to jdelliot/fizz
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/hsthrift
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/katran
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/hsthrift
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/rust-shed
that referenced
this pull request
Oct 29, 2023
…mental#43) Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/fb303
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/fizz
that referenced
this pull request
Oct 29, 2023
…tor#101) Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/openr
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
force-pushed
the
export-D50772544
branch
from
9c74d54 to
cce232c
Compare
jdelliot
pushed a commit
to jdelliot/katran
that referenced
this pull request
Oct 29, 2023
…tor#205) Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/folly
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/watchman
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/edencommon
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/fboss
that referenced
this pull request
Oct 29, 2023
Summary: X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/rust-shed
that referenced
this pull request
Oct 30, 2023
…mental#43) Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/sapling
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/edencommon
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/fbthrift
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/hsthrift
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/fb303
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/fboss
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/folly
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
pushed a commit
to jdelliot/proxygen
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
|
This pull request was exported from Phabricator. Differential Revision: D50772544 |
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 Pull Request resolved: #221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: #161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 Pull Request resolved: #43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 Pull Request resolved: #42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 Pull Request resolved: #763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 Pull Request resolved: #101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 Pull Request resolved: #205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 Pull Request resolved: #2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 Pull Request resolved: #7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 30, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/fboss#161 X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 Pull Request resolved: #9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544 fbshipit-source-id: caf00ade9b651965b6dd59e2cf0d8797d3ae1dce
|
This pull request has been merged in 7f78637. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/folly#2092
X-link: facebook/fb303#42
X-link: facebookincubator/velox#7301
We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option,
USE_CXX_INCLUDE, to the CMake function,rust_static_library, to enable adding thecxxbridgepath to the include path.Differential Revision: D50772544