-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Remove dep on build_devtools from run_devtools_e2e_tests #30348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jul 16, 2024
The run_devtools_e2e_tests job does not appear to actually need anything from the prior job since it always builds inline. Removing this dep allows us to run both in parallel. ghstack-source-id: 62e9eeb7ea7af0cbf94934669bf5510b28f460fe Pull Request resolved: #30348
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Jul 16, 2024
poteto
added a commit
that referenced
this pull request
Jul 16, 2024
The run_devtools_e2e_tests job does not appear to actually need anything from the prior job since it always builds inline. Removing this dep allows us to run both in parallel. ghstack-source-id: dd5c3f3d5c0cae14ff60564253b54bf5eb785fff Pull Request resolved: #30348
Comparing: fee423e...eb1e148 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
nvm, wrong assumption |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The run_devtools_e2e_tests job does not appear to actually need anything
from the prior job since it always builds inline. Removing this dep
allows us to run both in parallel.