GitHub workflow to ensure tests are up to date #1505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
8919306 to
fc5fbdf
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 9, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: cc8f6ad0f8482f2628da1619a0de54c4b8963587
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 2f143e41af665ae7534352e6e93b45d1d8f10de9
joevilches
force-pushed
the
export-D52002920
branch
from
fc5fbdf to
5e3b0ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
5e3b0ad to
c10a5af
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 24b173da1703c0927b7e778a896c4036075086f7
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
c10a5af to
1a1dd7c
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 38c1ddeb2f085a4da13f46fd3a51e92fb692c04c
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
1a1dd7c to
3d22882
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 3b8965ea404b4c725ab6d6fa2bd58dad44e3c9eb
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 4281c511e82eeaed9b0f4bf40ba36fa8e417db79
joevilches
force-pushed
the
export-D52002920
branch
from
3d22882 to
5d5f694
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
5d5f694 to
ca98a4b
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 4a64e36563b47ec8970a830f8ac5000dd4d9ec22
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 3db7415ffd1d65adeb00f9741158d5f1fd9f52b0
joevilches
force-pushed
the
export-D52002920
branch
from
ca98a4b to
03c629d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
03c629d to
a9b7d81
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 4d70df65d3fe0f353ba9e0b7df03cdf4fe366f9e
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: c177e60774d9b4f24e6aabeeffc79e8f19d3284f
joevilches
force-pushed
the
export-D52002920
branch
from
a9b7d81 to
24121e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: 549e2a1d4229935a3a6875ca73a5bd1aa839fc5e
joevilches
force-pushed
the
export-D52002920
branch
from
24121e6 to
62de68e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
62de68e to
0868cdc
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: debb439f3f928a95dd826db553b4442c1e3c8874
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
0868cdc to
e835a2c
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: bd451b128e46866c62b8f8ed060bc11e59378f4d
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
e835a2c to
7f25d51
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Differential Revision: D52002920 fbshipit-source-id: ec848d3c94f2ca0f5a72fbcda7e06e3dfca0f5b1
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
7f25d51 to
eeafe39
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 12, 2023
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Reviewed By: NickGerleman Differential Revision: D52002920 fbshipit-source-id: 24167da1bd10a18ea66239b337fcb32ac309e424
Summary: The only instance of ruby in this repository is `gentest.rb` used to generate test cases from html fixtures. This is quite annoying as ruby is not the most popular compared to something like Node and it does not integrate into the rest of our stack. I changed this to use Node.js instead. Instead of `watir` we now use `selenium-webdriver`. `watir` is backed by Selenium so I do not expect anything to change. Next commits will add command line options, clean up gentest.rb and its references, and change the README Differential Revision: https://www.internalfb.com/diff/D51874433?entry_point=27 fbshipit-source-id: 4cb290eb2776a68c81a1a51fe49b109e039c0c44
Summary: This uses the minimist library to parse the command line easily for flags and options. I added over the same ones in the ruby script (-f and -s). Unfortunately, there seems to be no way to fully suspend the script on command while waiting for user input like how you can in ruby. So, I am only able to suspend at the very end by not closing the browser immediately. Therefore, I only let this happen if -f is specified. Differential Revision: https://www.internalfb.com/diff/D51877810?entry_point=27 fbshipit-source-id: 7ae1b2cac8ff7253854f71fae5747bdcb2366ba5
Differential Revision: D51956567 fbshipit-source-id: 576e39c97057a52c76453dcd9c3f0cbd443b2e5a
Differential Revision: https://www.internalfb.com/diff/D51957351?entry_point=27 fbshipit-source-id: 8763d382ccad02a7c035f3ed5bdc176bac9cc164
Summary: This diff makes it so that our driver will sign all of the generated files to help ensure that they are not edited by hand. Next I will add CI to actually verify the signature Differential Revision: https://www.internalfb.com/diff/D51966201?entry_point=27 fbshipit-source-id: 3a5a82d186dc8a6907d3b89608fc741860a4bdd1
Differential Revision: D51999865 fbshipit-source-id: 4556bee0e1906ef3c1a7859956604b03dd8ddccf
Summary: Pull Request resolved: facebook#1505 This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :) Reviewed By: NickGerleman Differential Revision: D52002920 fbshipit-source-id: f0811a24c60d08da7455f848ad1eda02c6eb27e8
|
This pull request was exported from Phabricator. Differential Revision: D52002920 |
joevilches
force-pushed
the
export-D52002920
branch
from
eeafe39 to
3154aaa
Compare
|
This pull request has been merged in 43d09a3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This will ensure that all tests are not modified by hand and that gentest was run if needed (i.e. someone edited those files and forgot to update the tests). Not sure if this works right now, need to export to github and see what happens :)
Differential Revision: D52002920