refactor(parquet): Move arrow levelComparison to common #11711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
pedroerp
approved these changes
Dec 2, 2024
majetideepak
force-pushed
the
move-arrow-parquet
branch
from
11c7bb3 to
1b34db3
Compare
majetideepak
changed the title
majetideepak
force-pushed
the
move-arrow-parquet
branch
from
1b34db3 to
5b37e21
Compare
|
I moved it to draft mode to undo the unrelated thrift refactor. The changes now are minimal. |
|
Alright, let me know once you work through the CI failures. |
majetideepak
force-pushed
the
move-arrow-parquet
branch
5 times, most recently
from
5bc6b8d to
e46837c
Compare
|
@pedroerp this is ready, CI is green. Failing job is unrelated. |
pedroerp
approved these changes
Dec 4, 2024
pedroerp
added
the
ready-to-merge
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Struggling with the build system internally to unblock merge, will continue working on it tomorrow. |
|
@majetideepak do you mind replacing
in This would make it conform to how its being included in other places in velox like in ApproxDistinctAggregate.cpp, BinaryFunctions.h, etc.. and also resolves the include automatically. |
|
@bikramSingh91 I addressed this. Thanks again for helping with the merge. |
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bikramSingh91 merged this pull request in e983aac. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Summary: Follow-up PR: #11711 Both Parquet reader and writer depend on RleEncodingInternal. This currently resides in parquet/writer/arrow which introduces a dependency of the writer to the reader. No functional changes. CC: majetideepak pedroerp Pull Request resolved: #11795 Reviewed By: DanielHunte Differential Revision: D67152291 Pulled By: kgpai fbshipit-source-id: a4a1cc49718e8258cb9e170c44320e04ed3ac581
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…bator#11711) Summary: Both Parquet reader and writer depend on levelComparison. This currently resides in parquet/writer/arrow which introduces a dependency of the writer to the reader. Refactor to parquet common along with renaming variables to Velox coding convention. Fixes: facebookincubator#11678 Pull Request resolved: facebookincubator#11711 Reviewed By: mbasmanova Differential Revision: D66792888 Pulled By: bikramSingh91 fbshipit-source-id: 88b2cde1eb652762dcf5abc38508fa202aa143b1
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…incubator#11795) Summary: Follow-up PR: facebookincubator#11711 Both Parquet reader and writer depend on RleEncodingInternal. This currently resides in parquet/writer/arrow which introduces a dependency of the writer to the reader. No functional changes. CC: majetideepak pedroerp Pull Request resolved: facebookincubator#11795 Reviewed By: DanielHunte Differential Revision: D67152291 Pulled By: kgpai fbshipit-source-id: a4a1cc49718e8258cb9e170c44320e04ed3ac581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Parquet reader and writer depend on levelComparison.
This currently resides in parquet/writer/arrow which introduces a dependency of the writer to the reader.
Refactor to parquet common along with renaming variables to Velox coding convention.
Fixes: #11678