Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Remove test component of lib icu #11826

Closed
wants to merge 2 commits into from
Closed

build: Remove test component of lib icu #11826

wants to merge 2 commits into from

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Dec 11, 2024 •
edited
Loading

The test component of lib icu is not used in Velox. This pr simply removes it,
assuming there is no reason for keeping it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit dcb7cc8
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67591dededb1a60007d11253

@PHILO-HE
Copy link
Contributor Author

@assignUser, could you spare some time to review this small patch?

@PHILO-HE PHILO-HE mentioned this pull request Dec 11, 2024
Closed
assignUser
assignUser approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The component list was initially taken from boost iirc. So if that builds fine in resolve_dependenc it makes sense to remove test.

@PHILO-HE
Copy link
Contributor Author

@assignUser, thank you for confirming it! @majetideepak, could you also take a look?

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Dec 11, 2024
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 63fcb27.

athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
@PHILO-HE @athmaja-n
build: Remove test component of lib icu (facebookincubator#11826)
27cda88 
Summary:
The test component of lib icu is not used in Velox. This pr simply removes it,
assuming there is no reason for keeping it.

Pull Request resolved: facebookincubator#11826

Reviewed By: xiaoxmeng

Differential Revision: D67119218

Pulled By: kgpai

fbshipit-source-id: a1a91e2e6c07ce699b2c23bf999ef0793070bd38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@majetideepak majetideepak majetideepak approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PHILO-HE @facebook-github-bot @majetideepak @assignUser