Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove test component of lib icu #11826

Closed
wants to merge 2 commits into from
Closed

build: Remove test component of lib icu #11826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42fb6fb
Initial
PHILO-HE Dec 11, 2024
dcb7cc8
Remove it from cmake find
PHILO-HE Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CMake/resolve_dependency_modules/icu.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ set(icu_components
i18n
io
uc
tu
test)
tu)

foreach(component ${icu_components})
add_library(ICU::${component} SHARED IMPORTED)
Expand Down
7 changes: 6 additions & 1 deletion CMake/resolve_dependency_modules/icu/FindICU.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@
# limitations under the License.
message("Using ICU - Bundled")
set(ICU_FOUND TRUE)
set(icu_components data i18n io uc tu test)
set(icu_components
data
i18n
io
uc
tu)
foreach(component icu_components)
set(ICU_${component}_FOUND TRUE)
endforeach()
3 changes: 1 addition & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,7 @@ velox_resolve_dependency(
i18n
io
uc
tu
test)
tu)

set(BOOST_INCLUDE_LIBRARIES
atomic
Expand Down
Loading