Add unit tests for struct Converter #7884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
gggrace14
force-pushed
the
conversiontests
branch
from
20f5524 to
f4bbbbe
Compare
|
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gggrace14
force-pushed
the
conversiontests
branch
from
f4bbbbe to
e26180a
Compare
|
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kagamiori
approved these changes
Dec 7, 2023
velox/type/tests/ConversionsTest.cpp
Outdated
Comment on lines
397
to
400
| testConversion<float, int64_t>( | ||
| {kInf}, {}, /*truncate*/ false, false, /*expectError*/ true); | ||
| testConversion<float, int64_t>( | ||
| {kNan}, {0}, /*truncate*/ false, false, /*expectError*/ true); |
There was a problem hiding this comment.
nit: Can these two be combined into one testConversion call?
velox/type/tests/ConversionsTest.cpp
Outdated
Comment on lines
409
to
411
| testConversion<float, int64_t>( | ||
| {kInf}, {9223372036854775807}, /*truncate*/ true); | ||
| testConversion<float, int64_t>({kNan}, {0}, /*truncate*/ true); |
Add unit tests for struct Converter and Conversions.h. struct Converter holds the core logic for casting between scalar types. Source of the test cases are CastExprTest.cpp and https://facebookincubator.github.io/velox/functions/presto/conversion.html
gggrace14
force-pushed
the
conversiontests
branch
from
e26180a to
cd408cd
Compare
|
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thank you, @kagamiori Wei, for the quick review! |
|
@gggrace14 merged this pull request in 7249cd9. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for struct Converter and Conversions.h. struct Converter
holds the core logic for casting between scalar types. Source of the test
cases are CastExprTest.cpp and
https://facebookincubator.github.io/velox/functions/presto/conversion.html