Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vcpkg install path for azure lib #8663

Conversation

gaoyangxiaozhu
Copy link
Contributor

@gaoyangxiaozhu gaoyangxiaozhu commented Feb 3, 2024

This PR use to address this issue.
Resolves: #8622

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 09cc57a
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65be1c68228cc50008e11f2e

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2024
@gaoyangxiaozhu
Copy link
Contributor Author

@majetideepak fixed

Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gaoyangxiaozhu

@majetideepak majetideepak requested a review from kgpai February 5, 2024 01:28
@majetideepak
Copy link
Collaborator

@kgpai, please help merge this. Thanks!

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 7093d3b.

Copy link

Conbench analyzed the 1 benchmark run on commit 7093d3b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

FelixYBW pushed a commit to FelixYBW/velox that referenced this pull request Feb 10, 2024
Summary:
This PR use to address this issue.
Resolves: facebookincubator#8622

Pull Request resolved: facebookincubator#8663

Reviewed By: pedroerp

Differential Revision: D53500529

Pulled By: kgpai

fbshipit-source-id: d41df3de69aef5218e742191d9501590af14df73
FelixYBW pushed a commit to FelixYBW/velox that referenced this pull request Feb 12, 2024
Summary:
This PR use to address this issue.
Resolves: facebookincubator#8622

Pull Request resolved: facebookincubator#8663

Reviewed By: pedroerp

Differential Revision: D53500529

Pulled By: kgpai

fbshipit-source-id: d41df3de69aef5218e742191d9501590af14df73
FelixYBW pushed a commit to FelixYBW/velox that referenced this pull request Feb 12, 2024
Summary:
This PR use to address this issue.
Resolves: facebookincubator#8622

Pull Request resolved: facebookincubator#8663

Reviewed By: pedroerp

Differential Revision: D53500529

Pulled By: kgpai

fbshipit-source-id: d41df3de69aef5218e742191d9501590af14df73
FelixYBW pushed a commit to FelixYBW/velox that referenced this pull request Feb 12, 2024
Summary:
This PR use to address this issue.
Resolves: facebookincubator#8622

Pull Request resolved: facebookincubator#8663

Reviewed By: pedroerp

Differential Revision: D53500529

Pulled By: kgpai

fbshipit-source-id: d41df3de69aef5218e742191d9501590af14df73
FelixYBW pushed a commit to FelixYBW/velox that referenced this pull request Feb 12, 2024
Summary:
This PR use to address this issue.
Resolves: facebookincubator#8622

Pull Request resolved: facebookincubator#8663

Reviewed By: pedroerp

Differential Revision: D53500529

Pulled By: kgpai

fbshipit-source-id: d41df3de69aef5218e742191d9501590af14df73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build issue with azure/azure-sdk-for-cpp azure-storage-files-datalake_12.8.0
4 participants