Fix Ubuntu install script

[majetideepak]

Ubuntu script fails when you run it twice.
Add missing SUDO to other system commands in the helper function.
Check if conda is already present

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	ec28cda
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/65f385b8845d86000854bcab

[assignUser]

This was intentional to only install apt deps and use resolve_dependency for the rest, what is missing?

[majetideepak]

This was intentional to only install apt deps and use resolve_dependency for the rest, what is missing?

@assignUser thanks for the clarification. I will undo the workflow change.
Was this intent for all workflow files? We had to remove sourcing recently for the nightly jobs https://github.com/facebookincubator/velox/pull/8943/files

[assignUser]

@majetideepak Yes, my intention was to build the deps within the velox build so they can be cached by ccache (which we would need to manually setup for the projects otherwise). The idea being that the ccache would then speed up the overall time compared to building the deps stand alone. But with actions/cache being broken for build caching it doesn't matter for the moment.

But I would like to preserve a way to only install the apt/yum deps when using the setup scripts and (like you added in the other PR) a way to only install specific deps instead of all of them.

[kgpai]

Thanks, I will start the merge when the scheduled jobs pass.

[majetideepak]

Looks like the scheduled Fuzzer job is not testing this change which I thought it would.

[assignUser]

Looks like the scheduled Fuzzer job is not testing this change which I thought it would.

it's because it always checks out main, I fixed that in https://github.com/facebookincubator/velox/pull/8734/files#diff-f4109e225f86cb2508cacc3bd71f0782d0d42dd5caa207350bc8f72abbb18af3R82

(I also fixed the need for running the whole script vs sourcing it as well, but for local use this is of course still needed)

[majetideepak]

@kgpai can we merge this PR so that we can use it in #8734
Thanks!

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai merged this pull request in 84f94bc.