Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Build Metrics Report #9805

Closed
wants to merge 9 commits into from
Closed

Publish Build Metrics Report #9805

wants to merge 9 commits into from

Conversation

assignUser
Copy link
Collaborator

@assignUser assignUser commented May 14, 2024

This builds and uploads the build metric report after the nightly job: https://facebookincubator.github.io/velox/bm-report/

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2024
Copy link

netlify bot commented May 14, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 0b69693
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66500a7d5450b80008d3d3e5

assignUser and others added 6 commits May 15, 2024 00:33
clean up

add job to publish build metrics

add missing package

fix typo

add missing package

add gh token for remotes

add credentials

add missing suggested package for scales
fix default.nix
Revert "clean up"

This reverts commit 2c7c81a.

revert pretty
@assignUser assignUser changed the title WIP Publish Build Metrics Report Publish Build Metrics Report May 14, 2024
@assignUser assignUser marked this pull request as ready for review May 14, 2024 22:44
@assignUser assignUser requested review from kgpai and majetideepak May 14, 2024 22:44
Copy link
Contributor

@kgpai kgpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my brief knowledge of R , looks good.
Some minor nits.

.github/workflows/build-metrics.yml Show resolved Hide resolved
.github/workflows/build-metrics.yml Show resolved Hide resolved
scripts/bm-report/report.qmd Show resolved Hide resolved
@assignUser assignUser requested a review from kgpai May 24, 2024 04:41
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in ffe4cec.

Copy link

Conbench analyzed the 1 benchmark run on commit ffe4cecc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
Summary:
This builds and uploads the build metric report after the nightly job: https://facebookincubator.github.io/velox/bm-report/

Pull Request resolved: facebookincubator#9805

Reviewed By: Yuhta

Differential Revision: D57868005

Pulled By: kgpai

fbshipit-source-id: df268674388fce0f3d017b3d0eadf6673c544212
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
Summary:
This builds and uploads the build metric report after the nightly job: https://facebookincubator.github.io/velox/bm-report/

Pull Request resolved: facebookincubator#9805

Reviewed By: Yuhta

Differential Revision: D57868005

Pulled By: kgpai

fbshipit-source-id: df268674388fce0f3d017b3d0eadf6673c544212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants