-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example shiny app as a sandbox #3
base: main
Are you sure you want to change the base?
Conversation
Since it's always easier to show than tell: Screen.Recording.2022-05-05.at.11.11.22.am.mov |
Still TODO:
|
inst/shiny/sandbox/server.R
Outdated
|
||
observeEvent(input$add_module, { | ||
req(module_res()) | ||
result. <- sparrow::failWith(list(), FacileAnalysis::unreact(FacileAnalysis::faro(module_res()))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lianos this may be where I'm going wrong - I seem to get the fallback list()
. Not doing this step produces something that seems to error. Any guidance appreciated.
general cleanup
Now with filtering as an "output" that can be fed back in as an "input" Screen.Recording.2022-05-11.at.4.43.20.pm.movStill TODO:
|
inst/shiny/sandbox/server.R
Outdated
samples. <- .x | ||
sample.filter <- FALSE | ||
restrict_samples <- samples. | ||
} else if (is(.x, "ReactiveFacileDataStore")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is growing a bit too big, but I think this is the correct way to extract out the relevant parts - feel free to correct me, I'm still learning how these parts work.
version bump
…doubling of filters
…tion. Just realized that calling `samples()` on a FilteredReactiveFacileDataStore is getting you the universe, not the filtered subset [I do believe].
…eactiveFacileDataStore use active_samples
The doubled filters issue is now resolved and the right number of samples propagates through the filter into the result and retrieval by a later analysis. The |
This PR adds a shiny app in
inst/shiny/sandbox
which can load any offdge
,fpca
, orffsea
as modules.This is a barebones app with no additional features, merely a prototype for a sandbox in which modules could be loaded. This helped identify some minor issues (e.g. facilebio/FacileAnalysis#49 and something else happening with
ffsea
which crashes here). This also has some best-practices in terms of cleaning up destroyed modules. I've also used it to prototype the idea of keeping a running list of analyses performed - again, this is just a simple implementation.Dataset loading is limited to
FacileData:::exampleFacileDataSet()
.