Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten rest client and RestBackend follow-up #358

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

wirew0rm
Copy link
Member

Small follow up of #356 required to get subscriptions working.

The long polling index has to be properly updated to allow the
subscription to continue on reconnect.

Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm wirew0rm temporarily deployed to configure coverage November 12, 2024 17:27 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage November 12, 2024 17:27 — with GitHub Actions Inactive
@wirew0rm wirew0rm changed the title Emscripten rest client Emscripten rest client and RestBackend follow-up Nov 12, 2024
This part of the code was broken and adding the topic string again as a
context query parameter, which was confusing to the user as well as the
client implementations.

Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm wirew0rm force-pushed the emscriptenRestClient branch from 5b1c53f to ae98b74 Compare November 13, 2024 09:28
@wirew0rm wirew0rm temporarily deployed to configure coverage November 13, 2024 09:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage November 13, 2024 09:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage November 13, 2024 09:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage November 13, 2024 09:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage November 13, 2024 09:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage November 13, 2024 09:28 — with GitHub Actions Inactive
@RalphSteinhagen RalphSteinhagen merged commit e3cb6f9 into main Nov 13, 2024
9 checks passed
@RalphSteinhagen RalphSteinhagen deleted the emscriptenRestClient branch November 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants