fix(libsinsp): fix regression in signed comparison #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Guerra <[email protected]>
jasondellaluce
previously approved these changes
Jun 12, 2024
|
LGTM label has been added. Git tree hash: 06048a84b35a1ecb6b3005c344d01d4078e1bb47
|
|
/hold |
|
/hold adding a couple test to make sure this is actually fixed |
LucaGuerra
force-pushed
the
fix/signed_numeric_comparison
branch
from
df39a50 to
f69be8c
Compare
Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
fix/signed_numeric_comparison
branch
from
f69be8c to
90df565
Compare
|
/unhold |
|
LGTM label has been added. Git tree hash: 19fe676a31a4e0be180f14aaaddf7329d75ffc31
|
leogr
approved these changes
Jun 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incertum, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Libs 0.17.0 had some changes in numeric compare and casting. However, it looks like we are now doing unsigned comparison even if the data is signed, meaning that sinsp is thinking that
-1 > 10000. This requires a bit of testing to see if it is the case but we need to fix it for the next patch release. Also cover comparisons with tests.See: falcosecurity/falco#3245
/milestone 0.17.2
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: