Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libsinsp): fix regression in signed comparison #1905

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix(libsinsp): fix regression in signed comparison #1905

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e8960e
fix(libsinsp): fix regression in signed comparison
LucaGuerra Jun 12, 2024
90df565
update(tests): add tests for numeric compare
LucaGuerra Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion userspace/libsinsp/filter_compare.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ static inline void _throw_if_not_comparable(cmpop op, Check c)
}

template<typename T>
static inline bool flt_compare_numeric(cmpop op, uint64_t operand1, uint64_t operand2)
static inline bool flt_compare_numeric(cmpop op, T operand1, T operand2)
{
switch(op)
{
Expand Down
Loading