Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows build #2188

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area libscap-engine-savefile

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

fix windows build using OBJECT instead of STATIC

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97 Andreagit97 added this to the 0.20.0 milestone Dec 6, 2024
@poiana poiana requested review from hbrueckner and leogr December 6, 2024 15:15
@poiana poiana added the approved label Dec 6, 2024
@Andreagit97
Copy link
Member Author

Thank yu @FedeDP !

@poiana poiana added the size/XS label Dec 6, 2024
@Andreagit97 Andreagit97 force-pushed the fix_some_windows_issues branch from c06be0f to a03acc7 Compare December 6, 2024 15:15
Signed-off-by: Andrea Terzolo <[email protected]>
Co-authored-by: Federico Di Pierro <[email protected]>
@Andreagit97 Andreagit97 force-pushed the fix_some_windows_issues branch from a03acc7 to dc371fc Compare December 6, 2024 15:16
@poiana
Copy link
Contributor

poiana commented Dec 6, 2024

LGTM label has been added.

Git tree hash: 3920f7424b9bda02570800308991f034bb04e790

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Dec 6, 2024

Perf diff from master - unit tests

     3.06%     -0.34%  [.] sinsp_thread_manager::get_thread_ref
     0.91%     +0.31%  [.] sinsp_evt::get_ts
     2.75%     +0.28%  [.] sinsp_parser::process_event
     0.96%     -0.27%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     1.01%     -0.26%  [.] libsinsp::events::is_unknown_event
     1.30%     -0.26%  [.] sinsp::fetch_next_event
     4.44%     -0.24%  [.] gzfile_read
     0.32%     +0.23%  [.] scap_next
     1.82%     +0.22%  [.] next
     3.91%     -0.19%  [.] sinsp_evt::load_params

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0346         +0.0346           143           148           143           148
BM_sinsp_split_median                                          +0.0290         +0.0289           143           148           143           148
BM_sinsp_split_stddev                                         +10.5264        +10.4993             0             3             0             3
BM_sinsp_split_cv                                             +10.1405        +10.1143             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0756         +0.0756            57            61            57            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0742         +0.0742            56            61            56            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.0310         -0.0307             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0991         -0.0988             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0015         -0.0015            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   +0.0001         +0.0001            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8662         -0.8661             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8660         -0.8659             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1632         +0.1632            56            65            56            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.1667         +0.1667            55            65            55            65
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.4350         -0.4355             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.5143         -0.5147             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0117         +0.0117           386           390           386           390
BM_sinsp_split_container_image_median                          +0.0092         +0.0092           386           389           386           389
BM_sinsp_split_container_image_stddev                          -0.0739         -0.0747             3             3             3             3
BM_sinsp_split_container_image_cv                              -0.0846         -0.0854             0             0             0             0

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (7f160ac) to head (dc371fc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   75.19%   75.20%           
=======================================
  Files         259      259           
  Lines       33899    33890    -9     
  Branches     5799     5801    +2     
=======================================
- Hits        25492    25487    -5     
+ Misses       8407     8403    -4     
Flag Coverage Δ
libsinsp 75.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit 0b53bd7 into falcosecurity:master Dec 6, 2024
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants