-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix windows build #2188
chore: fix windows build #2188
Conversation
Thank yu @FedeDP ! |
c06be0f
to
a03acc7
Compare
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]>
a03acc7
to
dc371fc
Compare
LGTM label has been added. Git tree hash: 3920f7424b9bda02570800308991f034bb04e790
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2188 +/- ##
=======================================
Coverage 75.19% 75.20%
=======================================
Files 259 259
Lines 33899 33890 -9
Branches 5799 5801 +2
=======================================
- Hits 25492 25487 -5
+ Misses 8407 8403 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libscap-engine-savefile
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
fix windows build using OBJECT instead of STATIC
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: