Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fractionation metric #86

Merged
merged 11 commits into from
Jun 18, 2024
Merged

Add fractionation metric #86

merged 11 commits into from
Jun 18, 2024

Conversation

schmoelder
Copy link
Contributor

@schmoelder schmoelder commented Jan 10, 2024

To do

  • [>] Change registration of metrics in Comparator (would allow subclassing), closes Change behavior for adding Difference Metrics #36 (moved to Change behavior for adding Difference Metrics #102)
  • Add start/end times to Fraction class (missing: check end > start)
  • Add FractionationReference class
    • Time for Fraction must be provided!
    • Warning for overlaps
    • Volume (when compared with SolutionIO), define tolerance
    • Slicing (components, time etc.)
    • Plot methods
  • Add validate_reference_type to DifferenceMetrics (e.g. FractionationReference for FractionationSSE/Slide)
  • Implement FractionationSSE
    • Create fractions from solution
    • Calculate SSE

@schmoelder schmoelder force-pushed the add_fractionation_metric branch 2 times, most recently from 84832ce to 6fd2b4f Compare January 10, 2024 13:33
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from 6fd2b4f to e286e9b Compare January 11, 2024 07:18
@schmoelder schmoelder force-pushed the add_fractionation_metric branch 4 times, most recently from e4695ae to 804fb4c Compare January 22, 2024 11:34
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from 804fb4c to e91c880 Compare January 23, 2024 10:29
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from e91c880 to 6568bba Compare January 24, 2024 08:45
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from 6568bba to cf21d00 Compare January 24, 2024 08:53
@schmoelder schmoelder force-pushed the add_fractionation_metric branch 3 times, most recently from 203ed67 to 9462063 Compare February 7, 2024 15:53
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from 9462063 to 7023fab Compare February 14, 2024 17:04
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from 7023fab to f03e2e8 Compare March 2, 2024 12:27
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from f03e2e8 to 07f5d19 Compare March 2, 2024 12:48
@schmoelder schmoelder force-pushed the dev branch 2 times, most recently from a3e6c69 to 1f55438 Compare March 11, 2024 20:26
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from 07f5d19 to b93ea06 Compare March 11, 2024 20:27
@schmoelder schmoelder removed a link to an issue Mar 14, 2024
3 tasks
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from b93ea06 to c912bfd Compare March 14, 2024 18:57
@schmoelder schmoelder force-pushed the dev branch 2 times, most recently from 6a2eb4a to c3b4935 Compare March 15, 2024 10:16
@schmoelder schmoelder force-pushed the add_fractionation_metric branch from ad66ed0 to f3f75b0 Compare June 18, 2024 19:19
@schmoelder schmoelder merged commit 8f0faf6 into dev Jun 18, 2024
5 checks passed
@schmoelder schmoelder deleted the add_fractionation_metric branch June 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant