Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't set dummy preedit when switching IM for LibreOffice #172

Merged
merged 2 commits into from
Jul 13, 2024
Merged

fix: don't set dummy preedit when switching IM for LibreOffice #172

merged 2 commits into from
Jul 13, 2024

Conversation

eagleoflqj
Copy link
Member

Tested:

  • Terminal: ; and Return can input ascii semicolon.
  • Terminal: ESC can close an empty clipboard.
  • LibreOffice: Shift won't clear current cell.

Please approve and wait for fcitx/fcitx5#1085.

@eagleoflqj eagleoflqj requested a review from ksqsf July 6, 2024 04:24
ksqsf
ksqsf approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for upstream merge.

@eagleoflqj eagleoflqj merged commit 5ffb9bf into master Jul 13, 2024
1 check passed
@eagleoflqj eagleoflqj deleted the transient branch July 13, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eagleoflqj @ksqsf