frontend: add relationship between actions and projects/builds #2805
Conversation
nikromen
force-pushed
the
action-foreign-keys
branch
2 times, most recently
from
7abbf61
to
1546133
Compare
nikromen
force-pushed
the
action-foreign-keys
branch
from
1546133
to
cc3517b
Compare
|
I am setting blocked so we don't accidentally merge before this
|
|
Note that #2826 adds yet another migration script. |
| created_on=int(time.time()), | ||
| copr_id=copr_id, | ||
| ) | ||
| db.session.add(action) |
There was a problem hiding this comment.
This is weird, is the indent change intentional?
There was a problem hiding this comment.
yes. The send_delete_dirs_action works with multiple copr ids and I was thinking whether to create some new attribute copr_ids (array) but then I realised the object_type is "copr" so it confused me a bit and I was wondering if creating action for each copr_id will solve this
|
|
||
| def upgrade(): | ||
| op.add_column('action', sa.Column('copr_id', sa.Integer(), nullable=True)) | ||
| op.create_foreign_key(None, 'action', 'copr', ['copr_id'], ['id']) |
There was a problem hiding this comment.
note for myself: check this is synced
I actually think that we need to merge in vice-versa order :-) I just created a better tag for this than |
|
Ah, no - #2733 is different. |
nikromen
force-pushed
the
action-foreign-keys
branch
from
cc3517b
to
0efab6b
Compare
with this we can get information about Actions in projects and show it to user Closes: fedora-copr#2807
praiskup
force-pushed
the
action-foreign-keys
branch
from
0efab6b
to
910ed2c
Compare
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = '08dd42f4c304' | ||
| down_revision = 'daa62cd0743d' |
This will help to implement RFEs like #1108
TODO:
object_type(e.g. what is None?)testsThis PR just connects Copr and Action model, write tests for the RFEs like Better overview of actions being run, statues, etc. #1108Merge after #2733 and changedonedown_revisionto7d9f6f921fa0Closes #2823