Change the pyp2spec invocation #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait till this is in fedora and merge. Thank you very much for the update! |
|
one missing thing, @befeleme can you add a minimal pyp2spec version in Requires: in the corresponding spec file? |
pyp2spec 0.10.0 changed the API around the specfile generation. For fully-automated environments as copr is, the automode newly includes convenient defaults to make the specfiles as close to buildability as possible.
nikromen
approved these changes
Oct 29, 2024
|
JFYI: In Fedora 41 pyp2spec will be shipped tomorrow, it was stopped during the freeze. |
praiskup
reviewed
Oct 29, 2024
| @@ -56,7 +56,7 @@ def _produce_srpm_pyp2spec(self): | |||
| "pyp2spec", | |||
| self.pypi_package_name, | |||
| "--fedora-compliant", | |||
| "--top-level", | |||
There was a problem hiding this comment.
Why don't we need --top-level?
There was a problem hiding this comment.
It's included/hidden as implementation detail in the automode now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyp2spec 0.10.0 changed the API around the specfile generation. For fully-automated environments as copr is, the automode newly includes convenient defaults to make the specfiles as close to buildability as possible.
FYI: pyp2spec 0.10.0 is currently in bodhi, so during the next 7 days it'll get to all active Fedoras.