Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the pyp2spec invocation #3473

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Change the pyp2spec invocation #3473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rpmbuild/copr-rpmbuild.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Recommends: dist-git-client
Suggests: tito
Suggests: rubygem-gem2rpm
Suggests: pyp2rpm
Suggests: pyp2spec
Suggests: pyp2spec >= 0.10.0
%endif

%description
Expand Down Expand Up @@ -112,7 +112,7 @@ Requires: podman
# not supported
%else
Requires: pyp2rpm
Requires: pyp2spec
Requires: pyp2spec >= 0.10.0
Requires: rubygem-gem2rpm
Requires: scl-utils-build
Requires: fedora-review >= 0.8
Expand Down
2 changes: 1 addition & 1 deletion rpmbuild/copr_rpmbuild/providers/pypi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def _produce_srpm_pyp2spec(self):
"pyp2spec",
self.pypi_package_name,
"--fedora-compliant",
"--top-level",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need --top-level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included/hidden as implementation detail in the automode now.

"--automode",
]
if self.pypi_package_version:
cmd += ["-v", self.pypi_package_version]
Expand Down