Workaround dnf5 copr issue in snapshot-gating tmt plan #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchecahi
force-pushed
the
tmt-plan-dnf5-copr-fix
branch
from
c2a2a91
to
bebcf2d
Compare
dnf5 copr plugin has problems resolving the distname variable that we use in our Runtime dependency repos. This is needed to be able to use both fedora and rhel chroots. We will use dnf4 until the issue with dnf5 is resolved.
jchecahi
force-pushed
the
tmt-plan-dnf5-copr-fix
branch
from
bebcf2d
to
cdc455a
Compare
|
Tested on Fedora Rawhide with testing-farm. The coprdep baseurl is now processed correctly, and no more 404 errors when querying the repo: Full log link: https://artifacts.dev.testing-farm.io/a9293598-ec6d-4636-91d6-bc21f0123adb/work-snapshot-gatingx1flsele/log.txt |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kwk
requested changes
Aug 26, 2024
jchecahi
pushed a commit
to jchecahi/llvm-snapshots
that referenced
this pull request
Aug 27, 2024
Followup fedora-llvm-team#670. Reimplement without using a specific dnf. Replace the unexpanded $distname variable in the script
jchecahi
pushed a commit
to jchecahi/llvm-snapshots
that referenced
this pull request
Aug 27, 2024
Followup fedora-llvm-team#670. Reimplement without using a specific dnf. Replace the unexpanded $distname variable in the script
jchecahi
pushed a commit
to jchecahi/llvm-snapshots
that referenced
this pull request
Aug 28, 2024
Followup fedora-llvm-team#670. Reimplement without using a specific dnf. Replace the unexpanded $distname variable in the script
kwk
pushed a commit
that referenced
this pull request
Aug 28, 2024
This change fixes package installation issues in tmt runs due to dnf5 incompatibilities. Changes introduced: * Added a check to ensure that `llvm-libs` is a snapshots package coming from copr (`~pre` version) * Rewrite fix for dnf5 not resolving the copr runtime dependency repo. Implementation in #670 was forcing to use dnf4, while this one is dnf version agnostic. * Improve how `testing-farm-tag-repository` priority is handled. Before trying to modify the repo we check that it exists, hence we no longer need to mask the result of commands. This now works with both dnf4 and dnf5 Fixes #671 --------- Co-authored-by: Jesus Checa Hidalgo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnf5 copr plugin has problems resolving the distname variable that we use in our Runtime dependency repos. This is needed to be able to use both fedora and rhel chroots. We will use dnf4 until the issue with dnf5 is resolved.
Related upstream issue: fedora-copr/copr#3387