Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add sample_params method to effects and proper Lift test likelihood #149

Merged
merged 3 commits into from
Dec 15, 2024

Add sample_params to existing effects

c5752c3
Select commit
Loading
Failed to load commit list.
Merged

[ENH] Add sample_params method to effects and proper Lift test likelihood #149

Add sample_params to existing effects
c5752c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 15, 2024 in 0s

96.15% (-0.14%) compared to 552dcfb

View this Pull Request on Codecov

96.15% (-0.14%) compared to 552dcfb

Details

Codecov Report

Attention: Patch coverage is 96.21212% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.15%. Comparing base (552dcfb) to head (c5752c3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/prophetverse/effects/base.py 90.90% 2 Missing ⚠️
src/prophetverse/sktime/base.py 66.66% 2 Missing ⚠️
src/prophetverse/effects/lift_likelihood.py 98.03% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   96.28%   96.15%   -0.14%     
==========================================
  Files          39       40       +1     
  Lines        1535     1612      +77     
==========================================
+ Hits         1478     1550      +72     
- Misses         57       62       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov